Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Factor some common io::Error constants #123732

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Factor some common io::Error constants #123732

merged 1 commit into from
Apr 11, 2024

Conversation

a1phyr
Copy link
Contributor

@a1phyr a1phyr commented Apr 10, 2024

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Apr 10, 2024

r? @cuviper

rustbot has assigned @cuviper.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added O-hermit Operating System: Hermit O-SGX Target: SGX O-solid Operating System: SOLID O-unix Operating system: Unix-like O-wasi Operating system: Wasi, Webassembly System Interface O-windows Operating system: Windows S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 10, 2024
@cuviper
Copy link
Member

cuviper commented Apr 10, 2024

That's a nice cleanup, thanks!

@bors r+

@bors
Copy link
Contributor

bors commented Apr 10, 2024

📌 Commit 05e7396 has been approved by cuviper

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 10, 2024
fmease added a commit to fmease/rust that referenced this pull request Apr 10, 2024
@fmease
Rollup merge of rust-lang#123732 - a1phyr:io_error_factor, r=cuviper
8cb7d6a 
Factor some common `io::Error` constants
@fmease fmease mentioned this pull request Apr 10, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 10, 2024
@bors
Auto merge of rust-lang#123746 - fmease:rollup-pqkaizg, r=fmease
ec34ab5 
Rollup of 6 pull requests

Successful merges:

 - rust-lang#122470 (`f16` and `f128` step 4: basic library support)
 - rust-lang#122954 (Be more specific when flagging imports as redundant due to the extern prelude)
 - rust-lang#123314 (Skip `unused_parens` report for `Paren(Path(..))` in macro.)
 - rust-lang#123360 (Document restricted_std)
 - rust-lang#123703 (Use `fn` ptr signature instead of `{closure@..}` in infer error)
 - rust-lang#123732 (Factor some common `io::Error` constants)

r? `@ghost`
`@rustbot` modify labels: rollup
@tgross35
Copy link
Contributor

tgross35 commented Apr 10, 2024 •
edited
Loading

This looks to have failed in the rollup, https://github.com/rust-lang-ci/rust/actions/runs/8637707189/job/23680527190#step:27:3291

   error: associated constant `ZERO_TIMEOUT` is never used
    --> library/std/src/io/error.rs:93:22
     |
  79 | impl Error {
     | ---------- associated constant in this implementation
  ...
  93 |     pub(crate) const ZERO_TIMEOUT: Self =
     |                      ^^^^^^^^^^^^
     |
     = note: `-D dead-code` implied by `-D warnings`
     = help: to override `-D warnings` add `#[allow(dead_code)]`
  
  [RUSTC-TIMING] std test:false 2.337
  warning: `std` (lib) generated 1 warning
  error: could not compile `std` (lib) due to 1 previous error; 1 warning emitted

Probably need to gate some of these errors to specific platforms

@fmease
Copy link
Member

fmease commented Apr 10, 2024

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 10, 2024
@fmease
Copy link
Member

fmease commented Apr 10, 2024

@bors rollup=iffy exercises #[cfg]-heavy code

@cuviper
Copy link
Member

cuviper commented Apr 11, 2024

@bors r+

@bors
Copy link
Contributor

bors commented Apr 11, 2024

📌 Commit 9c64068 has been approved by cuviper

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 11, 2024
@bors
Copy link
Contributor

bors commented Apr 11, 2024

⌛ Testing commit 9c64068 with merge aa6a697...

@bors
Copy link
Contributor

bors commented Apr 11, 2024

☀️ Test successful - checks-actions
Approved by: cuviper
Pushing aa6a697 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 11, 2024
@bors bors merged commit aa6a697 into rust-lang:master Apr 11, 2024
12 checks passed
@bors bors mentioned this pull request Apr 11, 2024
Merged
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (aa6a697): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Warning ⚠: The following benchmark(s) failed to build:

  • rustc

cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -0.5% [-0.8%, -0.2%] 2
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -0.5% [-0.8%, -0.2%] 2

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 6.4% [5.2%, 7.5%] 2
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -4.4% [-4.4%, -4.4%] 1
All ❌✅ (primary) 6.4% [5.2%, 7.5%] 2

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 0.3% [0.1%, 1.1%] 11
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -0.1% [-1.0%, -0.0%] 18
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 0.0% [-1.0%, 1.1%] 29

Bootstrap: missing data
Artifact size: 315.97 MiB -> 315.97 MiB (-0.00%)

@cuviper cuviper added this to the 1.79.0 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cuviper cuviper cuviper left review comments

Assignees

@cuviper cuviper

Labels
merged-by-bors This PR was explicitly merged by bors. O-hermit Operating System: Hermit O-SGX Target: SGX O-solid Operating System: SOLID O-unix Operating system: Unix-like O-wasi Operating system: Wasi, Webassembly System Interface O-windows Operating system: Windows S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.79.0
Development

Successfully merging this pull request may close these issues.
7 participants
@a1phyr @rustbot @cuviper @bors @tgross35 @fmease @rust-timer